🌱 Improve mark hook utils #12994
Merged
🌱 Improve mark hook utils #12994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-improve-hook-utils
branch
from
a5f7631 to
55a23d5
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
Member
Author
|
/hold I'll take another look myself on Monday, but PR is ready for review |
k8s-ci-robot
added
the
do-not-merge/hold
Member
Author
|
/hold cancel All good /assign @fabriziopandini |
k8s-ci-robot
removed
the
do-not-merge/hold
Comment on lines
+158
to
+166
| if !updateResourceVersionOnObject { | ||
| obj = obj.DeepCopyObject().(client.Object) | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if !updateResourceVersionOnObject { | |
| obj = obj.DeepCopyObject().(client.Object) | |
| } | |
| // In some cases it is preferred to not update resourceVersion in the input object, | |
| // because this could lead to conflict errors e.g. when patching at the end of a reconcile loop. | |
| if !updateResourceVersionOnObject { | |
| obj = obj.DeepCopyObject().(client.Object) | |
| } |
Member
There was a problem hiding this comment.
Same in MarkAsDone/MarkAsOkToDelete
sbueringer
force-pushed
the
pr-improve-hook-utils
branch
from
55a23d5 to
1c2aeaa
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 805520d85d305d7e856787e5c4191c7d3c05c3e7
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes patchHelper to avoid unnecessary resource usage and gives callers a choice if the resourceVersion on the passed-in object should be updated.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #